Go: Implement ClientId #3077
Go: Implement ClientId #3077
Conversation
Signed-off-by: EdricCua <[email protected]>
Signed-off-by: EdricCua <[email protected]>
| if err != nil { | ||
| return createEmptyClusterValue[int64](), err | ||
| } | ||
| if opts.Route != nil && |
There was a problem hiding this comment.
I think we can remove the nil check here as the isMultiNode function has default implementation in request_routing_config.go :-
type Route interface {
ToRoutesProtobuf() (*protobuf.Routes, error)
IsMultiNode() bool
}
type notMultiNode struct{}
func (*notMultiNode) IsMultiNode() bool { return false }
Can you check once this ?
There was a problem hiding this comment.
Can a user call ClientIdWithOptions(nil)? If yes, we can remove this nil check. If no, we need to adjust API of this command or RouteOption to make route parameter optional.
There was a problem hiding this comment.
Hi @Yury-Fridlyand and @omangesg, I have to do opts.Route != nil to avoid error when doing the IsMultiNode() check.
func (route SimpleNodeRoute) IsMultiNode() bool {
return route != RandomRoute
}
| if err != nil { | ||
| return createEmptyClusterValue[int64](), err | ||
| } | ||
| if opts.Route != nil && |
There was a problem hiding this comment.
Can a user call ClientIdWithOptions(nil)? If yes, we can remove this nil check. If no, we need to adjust API of this command or RouteOption to make route parameter optional.
Signed-off-by: EdricCua <[email protected]>
Signed-off-by: EdricCua <[email protected]>
Signed-off-by: EdricCua <[email protected]>
Signed-off-by: EdricCua <[email protected]>
Issue link
This Pull Request is linked to issue (URL): [REPLACE ME]
Checklist
Before submitting the PR make sure the following are checked: